-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Добавлены мультиплеерные очки #2
base: master
Are you sure you want to change the base?
Conversation
Я же правильно понимаю, что это недоделанный еще 2 PR? И вы доделаете сюда тесты, а потом сделаете еще 3 рк с началами игровой механики? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
почините чеккер, тогда посмотрю
@@ -217,6 +217,22 @@ public SessionController(UserService service) { | |||
return ResponseEntity.ok(new MessageResponse(USER_PROFILE_UPDATED)); | |||
} | |||
|
|||
@PostMapping(path = "/api/win", consumes = JSON, produces = JSON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
класс вроде SessionController называется, при чем тут 'wins'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Костыль для проверки топа, пока нет игровой механики
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
давайте тогда будем делать топ вместе с игровой механикой. Пусть ручка пока отдает захардкоженный топ. Я так понимаю ее хотели на фронте, да?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Я тоже не совсем понял смысл этого пр. Это будут только очки? Или вы сюда игру добавите?
} | ||
query += "WHERE id = ? RETURNING score"; | ||
public Integer updateScoreS(long userId) { | ||
String query = "UPDATE users SET scoreS = scoreS + " + SCORE_CHANGE + " WHERE id = ? RETURNING scoreS"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
у вас в api есть ручка, которая увеличивает количество очков на скорборде? А какой в этом смысл?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Игру добавлю, а пока ее нет - "/api/win" нужен для проверки топа.
Как дела? Когда планируете добавить игру? |
No description provided.